Review main Merged

97354[BUGFIX] Respect public sub-folder for app resources

Oli Bartsch CR +2 V +2 Normal +86 −1 updated 11/05/26, 09:58

Commit message

In classic mode the virtual app package was created with a hardcoded
empty relative public path. Since a public folder inside the project
folder is supported in classic mode, this is wrong for such setups:
the default public resources "_assets", "uploads" and
"typo3temp/assets" were defined relative to the project folder instead
of the public folder. Files below "public/typo3temp/assets", such as
inline CSS and JavaScript written by the core, could then not be
resolved and an exception was thrown.

The package manager now passes the relative public path from the
environment, as Composer mode already does. With project path equal
to public path this is still an empty string.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/05/26, 07:58

  2. core-ci voted on patch set 1 V +1 11/05/26, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113356

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/05/26, 09:37

  4. Benni Mack voted on patch set 1 CR +1 V +1 11/05/26, 09:57

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 11/05/26, 09:58

  6. Oli Bartsch merged patch set 2 11/05/26, 09:58