Review main Merged

97355[BUGFIX] Respect record type for slug proposal of new records

Oli Bartsch CR +2 V +2 Normal +65 −2 updated 11/05/26, 13:20

Commit message

The slug suggestion AJAX controller determined the record type only
from the database row to apply the "columnsOverrides" of the type.
For new records no row exists, so the overrides were never applied
and the proposal was generated with the base "generatorOptions",
although FormEngine renders the slug element with the overridden
configuration, e.g. listening on different fields.

The record type resolved by FormEngine is now passed from
InputSlugElement via the slug JavaScript module to the controller
and is part of the HMAC. The controller uses it when it is a valid
type of the table and falls back to the database row otherwise.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Oli Bartsch uploaded patch set 1 11/05/26, 08:07

  2. core-ci voted on patch set 1 V +1 11/05/26, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113357

  3. core-ci voted on patch set 1 V -1 11/05/26, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113362

  4. Oli Bartsch rebased onto patch set 2 V -1 11/05/26, 10:00

  5. core-ci voted on patch set 2 V +1 11/05/26, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113383

  6. Oli Bartsch voted on patch set 2 CR +2 V +2 11/05/26, 10:15

  7. Oli Bartsch merged patch set 3 11/05/26, 10:15

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/05/26, 10:17

  9. Oli Bartsch wrote 11/05/26, 10:26

    Created a revert of this change as Ia62ecf2b1dc55a44e9a2a8a0eeb7d2c7af8d979b
  10. Benni Mack voted on patch set 3 CR +1 V +1 11/05/26, 13:20