Review main Merged

97356[TASK] Raise symfony/property-info to 8.1.11

Oli Bartsch CR +2 V +2 Easy +14 −12 updated 11/05/26, 10:32

Commit message

symfony/property-info 8.1.11 no longer resolves intersection types
from doc comments and falls back to the next extractor (upstream
commit 4dcdd28e9ea1). Before, a "@var \ArrayAccess&\Traversable"
property got the non-existing class name "ArrayAccess&\Traversable",
which a unit test asserted. This made the nightly builds with highest
dependencies fail.

Extbase now reports no type for a property whose only type is such a
doc comment intersection. Validating a model with such a property
throws exception 1363778104 instead of skipping the property.
Persisting or mapping such a property failed before and still fails,
now with clearer exceptions. Native intersection types now get both
types. Core does not use doc comment intersections. The behaviour
arrives with the upstream patch release regardless of the constraint.

The minimum version is raised so locked, lowest and highest
dependencies behave the same, and the test now expects no type.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1518

  1. Oli Bartsch uploaded patch set 1 11/05/26, 08:18

  2. Markus Klein commented on patch set 1 11/05/26, 08:25

    composer.lock:9210

    api-version downgrade?
  3. Markus Klein commented on patch set 1 11/05/26, 08:27

    Doesn't this have also functional consequences, if I used `@var` intersections currently in my code? Does extbase now still detect things correctly? (I didn't dig into our tests, if that is covered functionally)
  4. Oli Bartsch commented on patch set 1 V -1 11/05/26, 08:34

    needs proper review.
  5. core-ci voted on patch set 1 V +1 11/05/26, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113358

  6. Oli Bartsch uploaded patch set 2 V +1 11/05/26, 08:49

  7. Oli Bartsch commented on patch set 2 11/05/26, 08:57

    Reply

    Yes, for properties whose only type is a doc comment intersection, ClassSchema now reports no type and ValidatorResolver then throws instead of skipping the property, while also Backend::getPlainValue() fails on a null value. However, Persistence failed before as well, now with clearer exceptions. Native intersection types keep working and now get both types. AFAICS no core code uses doc intersections. I updated the commit message and will address the Backend null dereference in a separate bugfix.

    Reply

    Done

    composer.lock:9210 Reply

    The lock had plugin-api-version 2.9.0 in every commit before 792b5a2f790, which was written with Composer 2.11 (that also added "published-time"). Composer does not enforce the value. This restores what the runTests container produces.
  8. core-ci voted on patch set 2 V +1 11/05/26, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113368

  9. Benni Mack commented on patch set 2 CR +1 V +1 11/05/26, 09:18

    Reply

    Fine with this change now, even though I'd love if we could fix the todo in this test.
  10. Simon Schaufelberger commented on patch set 2 11/05/26, 09:34

    composer.lock:9210

    Please update composer locally
  11. Oli Bartsch uploaded patch set 3 CR +1 V +1 11/05/26, 09:53

  12. Oli Bartsch commented on patch set 3 11/05/26, 09:53

    composer.lock:9210 Reply

    Done
  13. Benni Mack voted on patch set 3 CR +1 V +1 11/05/26, 09:57

  14. core-ci voted on patch set 3 V +1 11/05/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113380

  15. Markus Klein commented on patch set 2 11/05/26, 10:15

    Reply

    > AFAICS no core code uses doc intersections. I believe so as well. thought more of extensions, since this affects v13+. But maybe that's an edge-case then.
  16. Markus Klein voted on patch set 3 CR +1 V +1 11/05/26, 10:16

  17. Oli Bartsch voted on patch set 3 CR +2 V +2 11/05/26, 10:32

  18. Oli Bartsch merged patch set 4 11/05/26, 10:32