97356[TASK] Raise symfony/property-info to 8.1.11
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Markus Klein +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Markus Klein +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1518
-
Oli Bartsch uploaded patch set 1 11/05/26, 08:18
-
Markus Klein commented on patch set 1 11/05/26, 08:25
-
Markus Klein commented on patch set 1 11/05/26, 08:27
Doesn't this have also functional consequences, if I used `@var` intersections currently in my code? Does extbase now still detect things correctly? (I didn't dig into our tests, if that is covered functionally) -
Oli Bartsch commented on patch set 1 V -1 11/05/26, 08:34
needs proper review. -
core-ci voted on patch set 1 V +1 11/05/26, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113358
-
Oli Bartsch uploaded patch set 2
V +111/05/26, 08:49 -
Oli Bartsch commented on patch set 2 11/05/26, 08:57
Reply
Yes, for properties whose only type is a doc comment intersection, ClassSchema now reports no type and ValidatorResolver then throws instead of skipping the property, while also Backend::getPlainValue() fails on a null value. However, Persistence failed before as well, now with clearer exceptions. Native intersection types keep working and now get both types. AFAICS no core code uses doc intersections. I updated the commit message and will address the Backend null dereference in a separate bugfix.Reply
Donecomposer.lock:9210ReplyThe lock had plugin-api-version 2.9.0 in every commit before 792b5a2f790, which was written with Composer 2.11 (that also added "published-time"). Composer does not enforce the value. This restores what the runTests container produces. -
core-ci voted on patch set 2 V +1 11/05/26, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113368
-
Benni Mack commented on patch set 2 CR +1 V +1 11/05/26, 09:18
Reply
Fine with this change now, even though I'd love if we could fix the todo in this test. -
Simon Schaufelberger commented on patch set 2 11/05/26, 09:34
composer.lock:9210Please update composer locally -
Oli Bartsch uploaded patch set 3
CR +1V +111/05/26, 09:53 -
Benni Mack voted on patch set 3 CR +1 V +1 11/05/26, 09:57
-
core-ci voted on patch set 3 V +1 11/05/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113380
-
Markus Klein commented on patch set 2 11/05/26, 10:15
Reply
> AFAICS no core code uses doc intersections. I believe so as well. thought more of extensions, since this affects v13+. But maybe that's an edge-case then. -
Markus Klein voted on patch set 3 CR +1 V +1 11/05/26, 10:16
-
Oli Bartsch voted on patch set 3 CR +2 V +2 11/05/26, 10:32
-
Oli Bartsch merged patch set 4 11/05/26, 10:32
composer.lock:9210