Review 14.3 Merged

97357[TASK] Raise symfony/property-info to 7.4.23

Oli Bartsch CR +2 V +2 Easy +13 −12 updated 11/05/26, 10:32

Commit message

symfony/property-info 7.4.23 no longer resolves intersection types
from doc comments and falls back to the next extractor (upstream
commit 4dcdd28e9ea1). Before, a "@var \ArrayAccess&\Traversable"
property got the non-existing class name "ArrayAccess&\Traversable",
which a unit test asserted. This made the nightly builds with highest
dependencies fail.

Extbase now reports no type for a property whose only type is such a
doc comment intersection. Validating a model with such a property
throws exception 1363778104 instead of skipping the property.
Persisting or mapping such a property failed before and still fails,
now with clearer exceptions. Native intersection types now get both
types. Core does not use doc comment intersections. The behaviour
arrives with the upstream patch release regardless of the constraint.

The minimum version is raised so locked, lowest and highest
dependencies behave the same, and the test now expects no type.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 46

  1. Oli Bartsch uploaded patch set 1 11/05/26, 08:18

  2. core-ci voted on patch set 1 V +1 11/05/26, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113359

  3. Oli Bartsch uploaded patch set 2 V +1 11/05/26, 08:54

  4. core-ci voted on patch set 2 V +1 11/05/26, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113369

  5. Oli Bartsch voted on patch set 2 CR +2 V +2 11/05/26, 10:32

  6. Oli Bartsch merged patch set 3 11/05/26, 10:32