97367[BUGFIX] Resolve doc comment intersection types in Extbase ClassSchema
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
Review log 2431
Show 46 earlier messages
-
Oli Bartsch uploaded patch set 1 11/05/26, 10:37
-
Oli Bartsch uploaded patch set 2 11/05/26, 10:47
-
core-ci voted on patch set 1 V +1 11/05/26, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113389
-
core-ci voted on patch set 2 V +1 11/05/26, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113392
-
Oliver Klee voted on patch set 2 V +1 11/05/26, 11:44
-
Markus Klein commented on patch set 2 CR +1 V +1 11/05/26, 12:25
Nice!
-
Markus Klein commented on patch set 2 11/05/26, 12:27
Can we actually drop the composer req "phpdocumentor/reflection-docblock": "^6.0.3 now? -
Oliver Klee commented on patch set 2 11/05/26, 12:32
Reply
I've just checked: This was the last usage of any classes from the `phpDocumentor\Reflection` namespace. So we indeed probably can drop the dependency. -
Oli Bartsch uploaded patch set 3
CR +1V +111/05/26, 13:10 -
Oliver Klee voted on patch set 3 CR +1 11/05/26, 13:14
-
Oli Bartsch uploaded patch set 4
CR +111/05/26, 13:15 -
Benni Mack voted on patch set 4 CR +1 V +1 11/05/26, 13:20
-
core-ci voted on patch set 3 V +1 11/05/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113404
-
Oli Bartsch uploaded patch set 5
CR +1V +111/05/26, 13:21 -
Oliver Klee commented on patch set 5 CR +1 V +1 11/05/26, 13:23
Reply
Done -
core-ci voted on patch set 4 V +1 11/05/26, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113406
-
core-ci voted on patch set 5 V +1 11/05/26, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113408
-
Benni Mack voted on patch set 5 CR +1 V +1 11/05/26, 14:20
-
Markus Klein commented on patch set 5 11/05/26, 16:24
composer.json:83not used anymore as well, right?composer.json:36not used anymore as well, right? -
Markus Klein uploaded patch set 6
CR +1V +111/05/26, 16:26 -
Markus Klein commented on patch set 5 11/05/26, 16:27
composer.json:83ReplyDonecomposer.json:36ReplyDone -
Oliver Klee voted on patch set 6 CR +1 V +1 11/05/26, 16:56
-
core-ci voted on patch set 6 V -1 11/05/26, 17:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113415
-
Markus Klein commented on patch set 6 11/05/26, 17:11
Hell: Message was: "Unable to use the "Symfony\Component\PropertyInfo\Extractor\PhpStanExtractor" class as the "phpdocumentor/type-resolver" package is not installed. Am I right... they have a dependency issue? -
Oli Bartsch uploaded patch set 7
CR +1V +111/06/26, 08:51 -
Oli Bartsch commented on patch set 7 11/06/26, 08:53
Reply
PhpStanExtractor needs `phpdocumentor/type-resolver` (constructor checks `class_exists(ContextFactory)`), but `symfony/property-info` only lists it as optional. So we must keep requiring it ourselves. -
core-ci voted on patch set 7 V +1 11/06/26, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113466
-
Benni Mack voted on patch set 7 CR +1 V +1 11/06/26, 09:16
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 11/06/26, 09:30
-
Oli Bartsch voted on patch set 7 CR +2 V +2 11/06/26, 09:36
-
Oli Bartsch merged patch set 8 11/06/26, 09:36