Review 14.3 Merged

97368[BUGFIX] Resolve doc comment intersection types in Extbase ClassSchema

Oli Bartsch CR +2 V +2 Easy +5 −8 updated 11/06/26, 09:36

Commit message

ClassSchema reads property types from doc comments with the
PhpDocExtractor of symfony/property-info, which is based on
phpdocumentor. Since symfony/property-info 7.4.23 it ignores
intersection types, leaving a property with only
"@var \ArrayAccess&\Traversable" without any type.

The PhpStanExtractor, which is based on phpstan/phpdoc-parser, is
added as fallback after the PhpDocExtractor. It resolves doc comment
intersection types to an IntersectionType, so such a property gets
both types, as native intersection types already do. All other doc
comments are still resolved by the PhpDocExtractor.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Oli Bartsch uploaded patch set 1 11/05/26, 10:38

  2. Oli Bartsch uploaded patch set 2 11/05/26, 10:47

  3. core-ci voted on patch set 1 V +1 11/05/26, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113390

  4. core-ci voted on patch set 2 V +1 11/05/26, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113393

  5. Oli Bartsch voted on patch set 2 CR +2 V +2 11/06/26, 09:36

  6. Oli Bartsch merged patch set 3 11/06/26, 09:36