Review main Merged

97381[BUGFIX] Resolve packages for download through the TER REST API

Benni Mack CR +2 V +2 Hard +500 −7 updated 11/09/26, 08:38

Commit message

Since #109582 the "Get Extensions" module browses TER live, but
downloads, the dependency check and the update check of installed
extensions still read the imported extension list. An extension
found in the module could not be installed until the list had been
updated.

ExtensionRepository now asks the TER REST API first and falls back
to the imported list when TER does not know an extension, can not be
reached, or "offlineMode" is enabled. A dependency naming a composer
package is resolved to its extension key through the search filter.
Packages resolved from a remote are marked as such, as they have no
database uid anymore.

TER's answer that an extension is unknown is cached, and system
extensions are not asked about at all, since the list of installed
extensions asks about every extension on every view.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 710

  1. Benni Mack uploaded patch set 1 11/06/26, 06:30

  2. Benni Mack uploaded patch set 2 11/06/26, 06:40

  3. core-ci voted on patch set 1 V -1 11/06/26, 06:48 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113454

  4. core-ci voted on patch set 2 V -1 11/06/26, 06:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113455

  5. Josua Vogel uploaded patch set 3 V -1 11/06/26, 10:06

  6. core-ci voted on patch set 3 V +1 11/06/26, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113481

  7. Georg Ringer voted on patch set 3 CR +1 V +1 11/07/26, 12:07

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/08/26, 19:43

  9. Benni Mack voted on patch set 3 CR +2 V +2 11/09/26, 08:38

  10. Benni Mack merged patch set 4 11/09/26, 08:38