Review 14.3 Merged

97388[BUGFIX] Guard replaceFile() against incomplete replace commands

Benni Mack CR +2 V +2 Easy +39 −3 updated 11/06/26, 20:30

Commit message

If a multipart request for replacing a file is cut off during the
upload, PHP only parses the fields sent before the file. The replace
command then lacks the upload position and the uploaded file, which
led to a PHP warning or, without an uploaded file, to a fatal error
in ExtendedFileUtility::replaceFile().

The method now stops with the existing "No file was uploaded for
replacement" message in these cases.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Benni Mack uploaded patch set 1 11/06/26, 09:10

  2. core-ci voted on patch set 1 V +1 11/06/26, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113473

  3. Georg Ringer rebased onto patch set 2 V +1 11/06/26, 20:18

  4. core-ci voted on patch set 2 V +1 11/06/26, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113525

  5. Georg Ringer voted on patch set 2 CR +2 V +2 11/06/26, 20:30

  6. Georg Ringer merged patch set 3 11/06/26, 20:30