Review main Merged

97389[BUGFIX] Allow disabling the XSL stylesheet of XML sitemaps

Benni Mack CR +2 V +2 Normal +132 −9 updated 11/06/26, 21:38

Commit message

Setting "plugin.tx_seo.config.xslFile" (or the per type or per
sitemap variant) to an empty value made the sitemap fail with an
InvalidSystemResourceIdentifierException, as the empty value was
passed on to the system resource factory.

An empty value now omits the xml-stylesheet processing instruction
and the related Content-Security-Policy mutation. The most specific
setting still wins, so the stylesheet can be disabled globally and
re-enabled for a single sitemap, or the other way round.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Lisa Kreitz +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Lisa Kreitz +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 67

  1. Benni Mack uploaded patch set 1 11/06/26, 09:13

  2. core-ci voted on patch set 1 V +1 11/06/26, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113474

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/06/26, 09:41

  4. Lisa Kreitz voted on patch set 1 CR +1 V +1 11/06/26, 10:09

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 11/06/26, 18:51

  6. Georg Ringer voted on patch set 1 CR +2 V +2 11/06/26, 20:50

  7. Benni Mack merged patch set 2 11/06/26, 21:38