Review main Merged

9739[TASK] PATH_thisScript is defined twice in bootstrap

Andy Grunwald CR +2 V +2 Easy +1 −9 updated 06/03/13, 20:49

Commit message

In index.php AND typo3/sysext/cms/tslib/index_ts.php
(which will be included in index.php) the constant
PATH_thisScript is defined.

The definition in typo3/sysext/cms/tslib/index_ts.php
is obsolete, because this will be checked via
if(!defined(...)).

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andy Grunwald +1
  • Verified V +2
    • Christian Kuhn +2
    • Andy Grunwald +1

Files 1

Review log 9

  1. Andy Grunwald uploaded patch set 2 04/11/12, 12:06

  2. Christian Kuhn uploaded patch set 4 04/11/12, 12:06

  3. Andy Grunwald uploaded patch set 3 04/11/12, 12:06

  4. Andy Grunwald commented on patch set 4 04/11/12, 12:06

    Verified; Looks good to me, but someone else must approve <3
  5. Mr. Jenkins commented on patch set 1 04/11/12, 12:06

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3602/ : FAILURE
  6. Mr. Jenkins commented on patch set 2 04/11/12, 12:06

  7. Mr. Jenkins commented on patch set 3 04/11/12, 12:06

  8. Christian Kuhn commented on patch set 4 V 0 04/11/12, 12:06

    by team member; Looks good to me, approved
  9. Christian Kuhn merged patch set 4 04/11/12, 12:06