Review 14.3 Merged

97392[BUGFIX] Report workspace state after toggling record visibility

Oli Bartsch CR +2 V +2 Easy +30 −1 updated 11/06/26, 21:24

Commit message

The visibility toggle in the Layout and Records modules updates the
button and record icon from the AJAX response. The response was built
from the live record, so inside a workspace it reported the live state
instead of the one just written to the workspace version. Hiding an
element whose live record is visible therefore left it shown until
the module was reloaded.

The record is now read with its workspace overlay.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oli Bartsch commented on patch set 1 11/06/26, 09:58

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/06/26, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113480

  3. Benni Mack commented on patch set 2 V -1 11/06/26, 11:15

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 11/06/26, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113502

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 11/06/26, 19:56

  6. Benni Mack voted on patch set 2 CR +2 V +2 11/06/26, 21:24

  7. Benni Mack merged patch set 3 11/06/26, 21:24