Review main Merged

97395[TASK] Test access to subpages of restricted pages by slug

Benni Mack CR +2 V +2 Easy +3 −3 updated 11/06/26, 21:23

Commit message

The slug request tests contain cases for subpages that inherit an
access restriction via "extendToSubpages". They were commented out
with a todo when the tests were added, as the frontend did not deny
access to such subpages back then.

The rootline check denies access to these subpages now and the
site error handlers respond with a 403, so the cases are enabled
again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Garvin Hicking +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Garvin Hicking +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 11/06/26, 10:55

  2. core-ci voted on patch set 1 V +1 11/06/26, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113499

  3. Josua Vogel voted on patch set 1 CR +1 V +1 11/06/26, 11:10

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/06/26, 15:15

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 11/06/26, 16:20

  6. Garvin Hicking voted on patch set 1 CR +1 V +1 11/06/26, 20:12

  7. Benni Mack voted on patch set 1 CR +2 V +2 11/06/26, 21:22

  8. Benni Mack merged patch set 2 11/06/26, 21:23