Review 13.4 Merged

97398[DOCS] Point changelog class references at the right extension

Garvin Hicking CR +2 V +2 Easy +19 −19 updated 11/06/26, 20:16

Commit message

A number of class references in the changelog name the right
class but put it in the wrong system extension or package. The
documented namespace has never held that class, so the
references do not resolve.

The eight BlowfishSalt references in 10.0/Breaking-87193 list
methods of Core\Crypto\PasswordHashing\BlowfishSalt. That class
never existed under that name, and the same file already lists
it correctly as Saltedpasswords\Salt\BlowfishSalt among the
removed classes.

The two references in 14.0/Feature-107568 are use statements in
the example event listener, which passes an Extbase validation
Error to addError() and resolves labels through the Form
TranslationService.

14.0/Feature-92760 documents the timezone option of f:format.date,
which is implemented by EXT:fluid rather than by the standalone
typo3fluid/fluid package.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 57

  1. Garvin Hicking commented on patch set 1 11/06/26, 18:38

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107356-UseRecordAPIInListModule.rst * typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107537-CreateVersionNumberedFileName.rst * typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107537-FilePathSanitizer.rst * typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107537-getPublicResourcesWebPath.rst * typo3/sysext/core/Documentation/Changelog/14.0/Feature-106232-ProvideRecordTitleProvider.rst * typo3/sysext/core/Documentation/Changelog/14.0/Feature-107568-IntroducePSR14BeforeRenderableIsValidatedEvent.rst * typo3/sysext/core/Documentation/Changelog/14.0/Feature-107791-ReportsModuleUsesSubmoduleOverview.rst * typo3/sysext/core/Documentation/Changelog/14.0/Feature-92760-ConfigurableTimezoneForDateViewHelper.rst * typo3/sysext/core/Documentation/Changelog/14.2/Feature-107289-AutomaticHistoryTrackingForExtbaseEntities.rst
  2. Garvin Hicking commented on patch set 2 11/06/26, 18:39

    Published edit on patch set 1.
  3. Garvin Hicking marked it ready for review 11/06/26, 18:39

  4. core-ci voted on patch set 1 V -1 11/06/26, 18:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113518

  5. core-ci voted on patch set 2 V +1 11/06/26, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113519

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 11/06/26, 20:16

  7. Garvin Hicking merged patch set 3 11/06/26, 20:16