Review main Merged

97407[TASK] Deprecate legacy language mode and overlay type

Benni Mack CR +2 V +2 Normal +201 −31 updated 11/07/26, 21:33

Commit message

LanguageAspect::getLegacyLanguageMode() and getLegacyOverlayType()
map the language aspect to the TypoScript options
config.sys_language_mode and config.sys_language_overlay, which have
been removed since TYPO3 v9.

getLegacyOverlayType() is not used in Core anymore.
getLegacyLanguageMode() is only used in PageInformationFactory, where
the language aspect is always created from a site language. Its
fallback chain is never empty and never "off", so the method always
returns "content_fallback" there, and the "strict" and default
branches are unreachable.

The unreachable branches are removed and both methods, as well as
the aspect properties "legacyLanguageMode" and "legacyOverlayType",
are deprecated. The page access failure reason
LANGUAGE_NOT_AVAILABLE_STRICT_MODE, which was only used by the
"strict" branch, is deprecated as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 67

  1. Benni Mack uploaded patch set 1 11/06/26, 21:34

  2. core-ci voted on patch set 1 V +1 11/06/26, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113537

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 11/06/26, 21:55

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/07/26, 01:17

  5. Georg Ringer voted on patch set 1 CR +1 V +1 11/07/26, 06:56

  6. Benni Mack voted on patch set 1 CR +2 V +2 11/07/26, 21:33

  7. Benni Mack merged patch set 2 11/07/26, 21:33