Review main Merged

97408[TASK] Use stubs in Messenger middleware tests

Wouter Wolters CR +2 V +2 Easy +16 −16 updated 11/06/26, 22:16

Commit message

Replace mocks without call expectations with stubs in the Doctrine
ping and close middleware tests to avoid PHPUnit notices. Keep mocks
where the tests verify method calls.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Wouter Wolters uploaded patch set 1 11/06/26, 21:58

  2. core-ci voted on patch set 1 V +1 11/06/26, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113543

  3. Benni Mack voted on patch set 1 CR +2 V +2 11/06/26, 22:16

  4. Benni Mack merged patch set 2 11/06/26, 22:16