Review 14.3 Merged

97416[BUGFIX] Skip translations detached in the same data map

Georg Ringer CR +2 V +2 Normal +191 −0 updated 11/07/26, 18:58

Commit message

When a default language record is saved, DataMapProcessor
synchronizes its values to the dependent translations found in the
database. If such a translation is part of the same data map, the
submitted version is used instead. In case the data map turns that
record into a default language record (or points it to another
parent or source), it is no longer a dependent translation and has
no localization state, which caused a fatal error:

  Call to a member function filterFieldNames() on null

This happens for example when updating records with an import that
uses the uid of an existing translation for a default language page.

Such detached records are now skipped during synchronization.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 46

  1. Georg Ringer commented on patch set 1 11/07/26, 18:29

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/07/26, 18:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113572

  3. Georg Ringer uploaded patch set 2 V -1 11/07/26, 18:46

  4. core-ci voted on patch set 2 V +1 11/07/26, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113573

  5. Georg Ringer voted on patch set 2 CR +2 V +2 11/07/26, 18:58

  6. Georg Ringer merged patch set 3 11/07/26, 18:58