Review 13.4 Merged

97422[BUGFIX] Properly recognize Ctrl+Drag and Drop on Windows Chrome

Garvin Hicking CR +2 V +2 Normal +88 −10 updated 11/09/26, 14:12

Commit message

Chrome on Windows presets `dropEffect` to "move" in dragenter and
dragover events, even while the Ctrl key is held.

The copy detection returned early on that value and never evaluated
the pressed modifier, so content elements in the page module and
pages in the page tree were always moved instead of copied.

The copy modifier key now takes precedence over a preset dropEffect. A
dropEffect of "copy" is still honored, so user agents can continue to
express the copy intention natively, and the intention determined
during dragover is carried over to the drop event.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 3

Files 3

Review log 57

  1. Garvin Hicking commented on patch set 1 11/08/26, 20:08

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/utility/drag-drop-utility.js
  2. Garvin Hicking uploaded patch set 2 11/08/26, 20:10

    backport
  3. core-ci voted on patch set 2 V +1 11/08/26, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113609

  4. core-ci voted on patch set 1 V -1 11/08/26, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113607

  5. Garvin Hicking marked it ready for review 11/09/26, 14:12

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 11/09/26, 14:12

  7. Garvin Hicking merged patch set 3 11/09/26, 14:12