Review main Merged

9743[BUGFIX] Custom HTML tags no longer malformed in IE

Bart Dubelaar CR +2 V +2 Easy +25 −3 updated 06/03/13, 20:49

Commit message

Custom HTML tags would get malformed while editing in IE.
If a tag is not present in HTML4 and the document mode
of IE is lower than IE9 Standards, then the tag is not
present in the DOM and not parsed correctly.
This is fixed by specifying possible custom tags in TSconfig
and creating dummy instances of the tags before loading
the contents in the DOM, also known as the Shiv trick.

Review

  • Code review CR +2
    • Stanislas Rolland +2
  • Verified V +2
    • Stanislas Rolland +2

Files 3

Review log 16

  1. Stanislas Rolland merged patch set 1 05/24/12, 14:08

    htmlarea.js:979

    This is needed only if (Ext.isIE6 || Ext.isIE7 || Ext.isIE8 || (Ext.isIE && this.document.documentMode < 9)) right?
  2. Stanislas Rolland commented on patch set 1 05/24/12, 14:08

    (1 inline comment)
  3. Stanislas Rolland uploaded patch set 2 05/24/12, 14:08

  4. Philipp Gampe commented on patch set 1 05/24/12, 14:08

    (3 inline comments) Please see inline comments.
    In case a new version is needed, please add 4.8 to the release line.

    class.tx_rtehtmlarea_base.php:892

    Please wrap with !empty

    htmlarea.js:979

    whitespace at EOL.

    htmlarea.js:998

    yet another whitespace
  5. Philipp Gampe commented on patch set 2 1 comment 05/24/12, 14:08

    Looks good to me, but someone else must approve Other than the whitespace, looks good.
  6. Stanislas Rolland uploaded patch set 4 05/24/12, 14:08

  7. Stanislas Rolland commented on patch set 4 V 0 05/24/12, 14:08

    by team member; Looks good to me, approved
  8. Stefan Neufeind commented on patch set 3 05/24/12, 14:08

    Looks good to me, but someone else must approve
  9. Philipp Gampe commented on patch set 3 05/24/12, 14:08

    Looks good to me, but someone else must approve
  10. Bart Dubelaar commented on patch set 3 05/24/12, 14:08

    Verified; Looks good to me, but someone else must approve Fixed the last whitespace issue. I cannot test it in IE with Browser Mode set to IE9 and Document Mode to IE8 as the RTE will throw an (unrelated) error. This shouldn't be an issue for 4.7 as the document mode will be set to IE9 by default.
  11. Bart Dubelaar uploaded patch set 3 05/24/12, 14:08

  12. Mr. Jenkins commented on patch set 1 05/24/12, 14:08

  13. Mr. Jenkins commented on patch set 2 05/24/12, 14:08

  14. Mr. Jenkins commented on patch set 3 05/24/12, 14:08

  15. Mr. Jenkins commented on patch set 4 05/24/12, 14:08

  16. Bart Dubelaar commented on patch set 4 05/24/12, 14:08

    @Stanislas: Could you initiate backports to 4.5 and 4.6 too?