9743[BUGFIX] Custom HTML tags no longer malformed in IE
Commit message
Review
-
Code review CR +2
- Stanislas Rolland +2
-
Verified V +2
- Stanislas Rolland +2
Files 3
Review log 16
-
Stanislas Rolland merged patch set 1 05/24/12, 14:08
-
Stanislas Rolland commented on patch set 1 05/24/12, 14:08
(1 inline comment) -
Stanislas Rolland uploaded patch set 2 05/24/12, 14:08
-
Philipp Gampe commented on patch set 1 05/24/12, 14:08
(3 inline comments) Please see inline comments.In case a new version is needed, please add 4.8 to the release line.class.tx_rtehtmlarea_base.php:892Please wrap with !emptyhtmlarea.js:979whitespace at EOL.htmlarea.js:998yet another whitespace -
Philipp Gampe commented on patch set 2 1 comment 05/24/12, 14:08
Looks good to me, but someone else must approve Other than the whitespace, looks good. -
Stanislas Rolland uploaded patch set 4 05/24/12, 14:08
-
Stanislas Rolland commented on patch set 4 V 0 05/24/12, 14:08
by team member; Looks good to me, approved -
Stefan Neufeind commented on patch set 3 05/24/12, 14:08
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 05/24/12, 14:08
Looks good to me, but someone else must approve -
Bart Dubelaar commented on patch set 3 05/24/12, 14:08
Verified; Looks good to me, but someone else must approve Fixed the last whitespace issue. I cannot test it in IE with Browser Mode set to IE9 and Document Mode to IE8 as the RTE will throw an (unrelated) error. This shouldn't be an issue for 4.7 as the document mode will be set to IE9 by default. -
Bart Dubelaar uploaded patch set 3 05/24/12, 14:08
-
Mr. Jenkins commented on patch set 1 05/24/12, 14:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3605/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/24/12, 14:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3615/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/24/12, 14:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3619/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/24/12, 14:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3867/ : SUCCESS -
Bart Dubelaar commented on patch set 4 05/24/12, 14:08
@Stanislas: Could you initiate backports to 4.5 and 4.6 too?
htmlarea.js:979