Review main Merged

97431[TASK] Use page ancestry for TypoScript rootlines in the backend

Benni Mack CR +2 V +2 Normal +70 −31 updated 11/10/26, 18:06

Commit message

The backend TypoScript modules - Active TypoScript, Constant Editor
and Template Analyzer - and the TypoScript code completion of the
code editor resolved the rootline of a page with the frontend
RootlineUtility. It applies language overlays and resolves relation
fields for every page, and its rootline is not shared with the page
ancestry already resolved for the same backend request.

These callers now use the PageAncestryResolver, which resolves the
ancestry with one query, cached for the request, in the workspace of
the backend user. The TypoScript module controllers get it via
AbstractTemplateModuleController::getRootLine(), which resolves the
former @todo to use the backend rootline with workspace overlay.

The same applies to the TypoScript of Extbase backend modules in
BackendConfigurationManager and to the page path of the "Latest
changed pages" dashboard widget. RecordIndexer of indexed_search
resolves the live ancestry, as the search index holds live content.
The frontend keeps using RootlineUtility.

PageAncestry::toLegacyRootLine() can now return the rootline without
the virtual tree root, in the structure of RootlineUtility::get() as
expected by TypoScript.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 56

  1. Benni Mack uploaded patch set 1 11/09/26, 12:11

  2. core-ci voted on patch set 1 V +1 11/09/26, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113665

  3. Georg Ringer voted on patch set 1 CR +1 V +1 11/09/26, 19:42

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 11/10/26, 18:05

  5. Benni Mack voted on patch set 1 CR +2 V +2 11/10/26, 18:06

  6. Benni Mack merged patch set 2 11/10/26, 18:06