Review main Merged

97434[BUGFIX] Link untranslated records in language mode "fallback"

Oli Bartsch CR +2 V +2 Normal +48 −4 updated 11/09/26, 16:03

Commit message

Sites with the language fallback type "fallback" render records of
the default language that are not translated. DatabaseRecordLinkBuilder
nevertheless refused to link such a record and rendered the link text
only, because it required a translation whenever overlays are active.

The check now relies on the result of the language overlay, which keeps
untranslated records in the overlay mode "mixed" and drops them in the
strict modes. Records are thus linked exactly when they are displayed.
Links to untranslated records in strict mode, see #87260, are still not
rendered.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 710

  1. Oli Bartsch uploaded patch set 1 11/09/26, 13:03

  2. Benni Mack commented on patch set 2 11/09/26, 13:13

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V +1 11/09/26, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113679

  4. core-ci voted on patch set 2 V -1 11/09/26, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113684

  5. Oli Bartsch uploaded patch set 3 V -1 11/09/26, 14:49

  6. Benni Mack voted on patch set 3 CR +1 V +1 11/09/26, 14:50

  7. core-ci voted on patch set 3 V +1 11/09/26, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113711

  8. Josua Vogel voted on patch set 3 CR +1 V +1 11/09/26, 15:20

  9. Oli Bartsch voted on patch set 3 CR +2 V +2 11/09/26, 16:03

  10. Oli Bartsch merged patch set 4 11/09/26, 16:03