Review main Merged

97435[BUGFIX] Map record links to imported records

Oli Bartsch CR +2 V +2 Normal +64 −2 updated 11/09/26, 21:07

Commit message

The import of records remaps soft references to records that are part
of the import. For record links, "t3://record?identifier=x&uid=42",
the token value is the whole link, which was cut at the first colon
and stored as "t3:<new uid>", a broken link.

The uid of a record link is now replaced within the link. Besides, the
soft reference parser for typolinks no longer includes target, class
and title of the typolink in the token value of a record link, which
duplicated them when the token was substituted.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Oli Bartsch uploaded patch set 1 11/09/26, 13:03

  2. core-ci voted on patch set 1 V +1 11/09/26, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113680

  3. Oli Bartsch uploaded patch set 2 V +1 11/09/26, 14:49

  4. core-ci voted on patch set 2 V +1 11/09/26, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113712

  5. Benni Mack voted on patch set 2 CR +1 V +1 11/09/26, 16:39

  6. Georg Ringer voted on patch set 2 CR +1 V +1 11/09/26, 19:41

  7. Oliver Klee voted on patch set 2 V +1 11/09/26, 20:29

  8. Oli Bartsch voted on patch set 2 CR +2 V +2 11/09/26, 21:07

  9. Oli Bartsch merged patch set 3 11/09/26, 21:07