Review main Merged

97438[BUGFIX] Read form metadata as complete YAML values

Josua Vogel CR +2 V +2 Normal +182 −62 updated 11/13/26, 09:27

Commit message

The metadata of form definition files (identifier, type, label and
prototypeName) is read line by line to avoid parsing complete files.
Values were taken from their first line only, so multi-line, quoted
or commented values ended up empty, truncated or with the comment.

Each metadata key is now parsed together with its following indented
lines by the YAML parser. Other parts of the file are still skipped,
so listing forms stays fast. The upgrade wizard migrating file-based
forms uses the same implementation instead of a copy of it.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Josua Vogel uploaded patch set 1 11/09/26, 13:44

  2. core-ci voted on patch set 1 V +1 11/09/26, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113687

  3. Josua Vogel rebased onto patch set 2 V +1 11/11/26, 16:08

  4. core-ci voted on patch set 2 V +1 11/11/26, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114124

  5. Benni Mack voted on patch set 2 CR +1 V +1 11/13/26, 08:18

  6. Georg Ringer voted on patch set 2 CR +1 V +1 11/13/26, 08:51

  7. Benni Mack voted on patch set 2 CR +2 V +2 11/13/26, 09:27

  8. Benni Mack merged patch set 3 11/13/26, 09:27