Review 14.3 Merged

97443[BUGFIX] Name only the known sender in the SystemEmail footer

Garvin Hicking CR +2 V +2 Normal +87 −3 updated 11/19/26, 09:17

Commit message

The footer of the SystemEmail layout always rendered "This email
was sent by {sitename} from URL: {siteUrl}", no matter which of
both values was known. Emails sent from CLI, e.g. by the scheduler,
have no request with a host, so the footer ended in "from URL: -"
or a broken URL like "http:/". An empty site name produced
"This email was sent by from URL: ...".

The footer now builds a complete sentence from the values that
are available: the site name, the site URL, both of them, or none,
in which case the sentence is omitted. The URL is only shown if
the request knows a host. It is kept whenever it is known, as it
helps to tell several instances with the same site name apart.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 3

Files 3

Review log 711

  1. Garvin Hicking commented on patch set 1 11/09/26, 14:30

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/09/26, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113707

  3. Garvin Hicking commented on patch set 2 V -1 11/09/26, 15:43

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 11/09/26, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113728

  5. Oliver Klee voted on patch set 2 V +1 11/09/26, 20:29

  6. Garvin Hicking commented on patch set 3 V +1 11/19/26, 07:20

    Cherry Picked from branch main.
  7. core-ci voted on patch set 3 V -1 11/19/26, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114965

  8. Garvin Hicking commented on patch set 4 V -1 11/19/26, 07:36

    Published edit on patch set 3.
  9. core-ci voted on patch set 4 V +1 11/19/26, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114966

  10. Garvin Hicking voted on patch set 4 CR +2 V +2 11/19/26, 09:16

  11. Garvin Hicking merged patch set 5 11/19/26, 09:17