Review main Merged

97449[FEATURE] Declare backend page context public API

Benni Mack CR +2 V +2 Normal +166 −9 updated 11/11/26, 14:14

Commit message

Backend modules using the page tree and routes with the option
"requestPageContext" receive the request attribute "pageContext".
It holds the requested page, determined from the "id" argument or
from an "edit" or "cmd" statement, together with its site, ancestry,
page TSconfig, the permissions of the user and the selected
languages.

PageContext and the language objects it exposes,
PageLanguageInformation, LanguageItem and LanguageStatus, are now
public API, so extensions no longer need to determine the current
page of a backend request themselves. Their constructors remain
internal.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 810

  1. Benni Mack uploaded patch set 1 11/09/26, 15:59

  2. core-ci voted on patch set 1 V +1 11/09/26, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113731

  3. Georg Ringer voted on patch set 1 CR +1 V +1 11/09/26, 20:22

  4. Oli Bartsch commented on patch set 1 CR +1 V +1 11/10/26, 07:28

    Added some remarks, which are however not blocking.

    Feature-93789-AccessThePageContextOfBackendRequests.rst:24

    forms does not use the tree component.

    Feature-93789-AccessThePageContextOfBackendRequests.rst:26

    I'm not quite sure if this was intended to be public API. I actually had to look up myself where this option is set as there is no documentation for it currently at all.
  5. Oli Bartsch commented on patch set 2 CR +1 V +1 11/11/26, 13:11

    Published edit on patch set 1.
  6. core-ci voted on patch set 2 V +1 11/11/26, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114078

  7. Oli Bartsch commented on patch set 2 CR +1 V +1 11/11/26, 14:10

    Feature-93789-AccessThePageContextOfBackendRequests.rst:24 Reply

    Done

    Feature-93789-AccessThePageContextOfBackendRequests.rst:26 Reply

    Done
  8. Josua Vogel voted on patch set 2 CR +1 V +1 11/11/26, 14:13

  9. Benni Mack voted on patch set 2 CR +2 V +2 11/11/26, 14:14

  10. Benni Mack merged patch set 3 11/11/26, 14:14