9747[BUGFIX] Creating new pages via drag'n'drop respects page TS
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Stefan Neufeind +1
- Georg Ringer +1
- Philipp Gampe +1
-
Verified V +2
- Steffen Ritter +2
- Georg Ringer +1
- Philipp Gampe +1
Files 1
Review log 15
-
Philipp Gampe commented on patch set 2 03/26/12, 14:39
(2 inline comments) I will push a new version as soon as I tested.4.8 tooclass.t3lib_tree_pagetree_commands.php:138Use (capital U) -
Stefan Neufeind commented on patch set 3 1 comment 03/26/12, 14:39
Looks good to me, but someone else must approve great you figured out how to cleanly do it. definitely makes sense this way by reading -
Stefan Neufeind commented on patch set 4 03/26/12, 14:39
Looks good to me, but someone else must approve -
Georg Ringer uploaded patch set 4 03/26/12, 14:39
-
Georg Ringer commented on patch set 4 03/26/12, 14:39
Verified; Looks good to me, but someone else must approve just wording change -
Steffen Ritter commented on patch set 4 V 0 03/26/12, 14:39
by team member; Looks good to me, approved -
Philipp Gampe uploaded patch set 3 03/26/12, 14:39
-
Philipp Gampe commented on patch set 3 03/26/12, 14:39
Verified; Looks good to me, but someone else must approve I pushed the new version as promised. In addition to my comments, I also move the calls to $parentNode->getWorkspaceId() to a temporary variable to avoid the need to call the same function twice. -
Philipp Gampe commented on patch set 4 03/26/12, 14:39
Verified; Looks good to me, but someone else must approve -
anonymized-50850 uploaded patch set 2 03/26/12, 14:39
-
Mr. Jenkins commented on patch set 1 03/26/12, 14:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3606/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/26/12, 14:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3607/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/26/12, 14:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3608/ : SUCCESS -
Mr. Jenkins commented on patch set 4 03/26/12, 14:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3650/ : SUCCESS -
Steffen Ritter merged patch set 4 03/26/12, 14:39