Review main Merged

9747[BUGFIX] Creating new pages via drag'n'drop respects page TS

anonymized-50850 CR +2 V +2 Easy +14 −5 updated 06/03/13, 20:49

Commit message

When creating a new page node via drag'n'drop shortcuts in pagetree,
the TCAdefaults.pages array from page TsConfig is now being respected.
This allows to preset certain field values for new pages.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Ritter +2
    • Georg Ringer +1
    • Philipp Gampe +1

Files 1

Review log 15

  1. Philipp Gampe commented on patch set 2 03/26/12, 14:39

    (2 inline comments) I will push a new version as soon as I tested.
    4.8 too

    class.t3lib_tree_pagetree_commands.php:138

    Use (capital U)
  2. Stefan Neufeind commented on patch set 3 1 comment 03/26/12, 14:39

    Looks good to me, but someone else must approve great you figured out how to cleanly do it. definitely makes sense this way by reading
  3. Stefan Neufeind commented on patch set 4 03/26/12, 14:39

    Looks good to me, but someone else must approve
  4. Georg Ringer uploaded patch set 4 03/26/12, 14:39

  5. Georg Ringer commented on patch set 4 03/26/12, 14:39

    Verified; Looks good to me, but someone else must approve just wording change
  6. Steffen Ritter commented on patch set 4 V 0 03/26/12, 14:39

    by team member; Looks good to me, approved
  7. Philipp Gampe uploaded patch set 3 03/26/12, 14:39

  8. Philipp Gampe commented on patch set 3 03/26/12, 14:39

    Verified; Looks good to me, but someone else must approve I pushed the new version as promised. In addition to my comments, I also move the calls to $parentNode->getWorkspaceId() to a temporary variable to avoid the need to call the same function twice.
  9. Philipp Gampe commented on patch set 4 03/26/12, 14:39

    Verified; Looks good to me, but someone else must approve
  10. anonymized-50850 uploaded patch set 2 03/26/12, 14:39

  11. Mr. Jenkins commented on patch set 1 03/26/12, 14:39

  12. Mr. Jenkins commented on patch set 2 03/26/12, 14:39

  13. Mr. Jenkins commented on patch set 3 03/26/12, 14:39

  14. Mr. Jenkins commented on patch set 4 03/26/12, 14:39

  15. Steffen Ritter merged patch set 4 03/26/12, 14:39