Review main Merged

97472[BUGFIX] Do not leave temporary copies of mask images behind

Benni Mack CR +2 V +2 Easy +28 −1 updated 11/11/26, 16:12

Commit message

Image processing with mask images requested a writable local copy
of each mask file. On local storages this copies the file into
var/transient/ as "fal-tempfile-*" on every processing run, and
the copy was never removed.

The mask images are only read, so the read-only local path is
requested instead, which is the original file on local storages.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Benni Mack uploaded patch set 1 11/09/26, 20:50

  2. core-ci voted on patch set 1 V +1 11/09/26, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113787

  3. Benni Mack marked it ready for review 11/09/26, 21:24

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 11/09/26, 21:27

  5. Georg Ringer voted on patch set 1 CR +1 V +1 11/09/26, 21:52

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/10/26, 12:47

  7. Josua Vogel voted on patch set 1 CR +1 V +1 11/10/26, 13:07

  8. Benni Mack voted on patch set 1 CR +2 V +2 11/11/26, 16:12

  9. Benni Mack merged patch set 2 11/11/26, 16:12