Review 14.3 Merged

97475[TASK] Prevent unnecessary rootline lookups in PageLinkBuilder

Benni Mack CR +2 V +2 Normal +135 −1 updated 11/09/26, 21:44

Commit message

The PageLinkBuilder needs to find the site of a page to be able
to link it. For every page link, the rootline of the target page
is resolved, although the page record itself is already known.

SiteFinder::getSiteByPage() now receives the resolved page and
only looks up the rootline of its parent page. This rootline is
usually already in the runtime cache when rendering menus, as all
siblings share the same parent, so fetching, enriching and caching
the record of every linked page is avoided.

This speeds up the link generation especially for pages without
mount points and on pages with the same PID.

Links with a mount point parameter still resolve the full rootline
of the target page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 46

  1. Benni Mack commented on patch set 1 11/09/26, 21:07

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/09/26, 21:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113792

  3. Benni Mack commented on patch set 2 V -1 11/09/26, 21:25

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 11/09/26, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113800

  5. Benni Mack voted on patch set 2 CR +2 V +2 11/09/26, 21:44

  6. Benni Mack merged patch set 3 11/09/26, 21:44