Review main Merged

97476[BUGFIX] Resolve empty FlexForm sections to an empty array

Benni Mack CR +2 V +2 Easy +49 −1 updated 11/10/26, 06:01

Commit message

When all elements of a FlexForm section are removed, the section is
stored as an empty "el" node. FlexFormTools resolved such a section
to an empty string instead of an empty array, both in
convertFlexFormContentToArray() and in
convertFlexFormContentToSheetsArray(). Code iterating or counting the
elements, such as Extbase plugin settings, the FlexFormProcessor or
the Record API, had to check for a string first.

Empty sections are now resolved to an empty array, like sections
with elements are resolved to an array of them.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 11/09/26, 21:11

  2. Benni Mack marked it ready for review 11/09/26, 21:25

  3. core-ci voted on patch set 1 V +1 11/09/26, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113794

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 11/09/26, 21:31

  5. Georg Ringer voted on patch set 1 CR +1 V +1 11/09/26, 21:52

  6. Benni Mack voted on patch set 1 CR +2 V +2 11/10/26, 06:01

  7. Benni Mack merged patch set 2 11/10/26, 06:01