Review 14.3 Merged

97479[BUGFIX] Fix password hash options in Install Tool

Georg Ringer CR +2 V +2 Normal +89 −6 updated 11/09/26, 22:15

Commit message

The password hashing options were declared as a plain list, so editing
them in "Configure Installation-Wide Options" dropped the option names
and the hash mechanisms silently used their defaults. Their description
also did not say what to enter, and the class name had no description
at all.

The options are now a key/value map and name the options and ranges of
each mechanism. To allow adding items to it, the row template lookup
escapes its identifier, which contains a slash for settings below a
container.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 46

  1. Georg Ringer commented on patch set 1 11/09/26, 21:44

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/09/26, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113807

  3. Georg Ringer uploaded patch set 2 V -1 11/09/26, 22:00

  4. core-ci voted on patch set 2 V +1 11/09/26, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113811

  5. Georg Ringer voted on patch set 2 CR +2 V +2 11/09/26, 22:14

  6. Georg Ringer merged patch set 3 11/09/26, 22:15