Review main Merged

97496[BUGFIX] Only check used capture groups for unsafe redirect regex

Benni Mack CR +2 V +2 Normal +61 −1 updated 11/12/26, 13:41

Commit message

The warning about unsafe capturing groups was logged for every
match of a regexp redirect, including match zero, which always
contains the query string when "Respect GET parameters" is set.

Capture groups not referenced in the redirect target are now
skipped, so the warning is only logged when a used group would
leak query parameters into the target URL.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Benni Mack uploaded patch set 1 11/10/26, 06:23

  2. core-ci voted on patch set 1 V -1 11/10/26, 06:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113836

  3. Benni Mack rebased onto patch set 2 V -1 11/10/26, 07:44

  4. core-ci voted on patch set 2 V +1 11/10/26, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113853

  5. Benni Mack marked it ready for review 11/10/26, 08:06

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/10/26, 17:07

  7. Georg Ringer voted on patch set 2 CR +1 V +1 11/11/26, 20:26

  8. Oliver Klee voted on patch set 2 CR +1 V +1 11/11/26, 20:47

  9. Benni Mack voted on patch set 2 CR +2 V +2 11/12/26, 13:41

  10. Benni Mack merged patch set 3 11/12/26, 13:41