Review main Merged

97498[TASK] Avoid duplicate slug_8 field in styleguide

Benni Mack CR +2 V +2 Easy +17 −19 updated 11/10/26, 07:28

Commit message

Two changes each added a field "slug_8" to the styleguide table
"tx_styleguide_elements_slugs". PHP keeps only the last array key,
so the required slug field was overwritten by the postModifiers
showcase and the slug e2e test failed.

The required field is renamed to "slug_9", the e2e test is adapted.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 57

  1. Benni Mack uploaded patch set 1 11/10/26, 07:13

  2. Benni Mack commented on patch set 2 11/10/26, 07:17

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V +1 11/10/26, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113843

  4. core-ci voted on patch set 2 V +1 11/10/26, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113844

  5. Josua Vogel voted on patch set 2 CR +1 V +1 11/10/26, 07:28

  6. Benni Mack voted on patch set 2 CR +2 V +2 11/10/26, 07:28

  7. Benni Mack merged patch set 3 11/10/26, 07:28