Review main Ready for review

97500[TASK] Resolve site of a site root page without rootline lookup

Alexander Schnitzler CR 0 V 0 Normal +116 −9 updated 11/10/26, 08:51

Commit message

SiteFinder->getSiteByPageId() loaded the full rootline of a page even
if the page itself is the root page of a site. The nearest site in the
rootline of a site root is always the page itself.

This is costly for installations with many sites, as the
PageSlugCandidateProvider asks for the site of every candidate page
and each site root has the slug "/".

The site is now returned directly for the root page of a valid site,
unless a rootline or a mount point parameter is given.
SiteFinder->getSiteByPage() skips loading the rootline of the parent
page for site root pages, too.

A deleted page configured as site root is now resolved to its site.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/00/97500/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/00/97500/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 4

Files 3

Review log 35

  1. Alexander Schnitzler uploaded patch set 1 11/10/26, 07:39

  2. core-ci voted on patch set 1 V -1 11/10/26, 07:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113850

  3. Alexander Schnitzler rebased onto patch set 2 V -1 11/10/26, 08:40

  4. core-ci voted on patch set 2 V +1 11/10/26, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113861

  5. Alexander Schnitzler commented on patch set 2 11/10/26, 08:51

    This change is ready for review.