Review main Merged

97508[TASK] Guide test level and test doubles in agent guidelines

Oli Bartsch CR +2 V +2 Easy +24 −1 updated 11/11/26, 09:14

Commit message

Agents follow the rule to reproduce a bug with a test first and tend
to write functional tests for that, even where a unit test can
reproduce the bug. Every functional test runs on each supported DBMS
in CI and makes the pipeline considerably slower. Pushing them toward
unit tests alone, however, produces tests that rebuild the framework
from mocks and accessible proxies, which prove little and break on
every refactoring.

AGENTS.md now picks the test level by what the subject needs to run,
sets rules for test doubles (real objects first, stubs over mocks, no
partial mocks of the subject, no access to protected members), and
asks to extend existing functional test cases before adding new ones.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Oli Bartsch uploaded patch set 1 11/10/26, 11:01

  2. Oli Bartsch updated the commit message in patch set 2 11/10/26, 11:04

  3. Josua Vogel voted on patch set 2 CR +1 V +1 11/10/26, 11:22

  4. core-ci voted on patch set 1 V -1 11/10/26, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113879

  5. core-ci voted on patch set 2 V +1 11/10/26, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113883

  6. Benni Mack commented on patch set 2 11/10/26, 18:17

    AGENTS.md:217

    question is if we want to mock + stub all the time?
  7. Oli Bartsch uploaded patch set 3 CR +1 V +1 11/10/26, 22:43

  8. Oli Bartsch commented on patch set 3 11/10/26, 22:44

    AGENTS.md:217 Reply

    Done
  9. core-ci voted on patch set 3 V +1 11/10/26, 22:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113994

  10. Josua Vogel voted on patch set 3 CR +1 V +1 11/11/26, 06:25

  11. Benni Mack voted on patch set 3 CR +1 V +1 11/11/26, 07:31

  12. Oliver Klee voted on patch set 3 CR +1 11/11/26, 08:39

  13. Oli Bartsch voted on patch set 3 CR +2 V +2 11/11/26, 09:14

  14. Oli Bartsch merged patch set 4 11/11/26, 09:14