Review main Ready for review

97517[BUGFIX] Find extensions added to an empty extensions directory

Benni Mack CR -1 V +1 Normal +84 −7 updated 11/18/26, 14:10

Commit message

The PackageManager memorized its package base paths on first use and
omitted typo3conf/ext/ when that directory had no subdirectories.

Uploading an extension in the Extension Manager checks its
availability before extracting the archive, which triggers this first
scan. In a classic mode installation without local extensions, the
rescan after extraction therefore never looked into typo3conf/ext/,
and the automatic installation failed with "Extension ... is not
available".

The base paths are now evaluated on every scan.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/17/97517/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/17/97517/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Markus Klein -1
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 912

  1. Benni Mack uploaded patch set 1 11/10/26, 12:23

  2. Benni Mack marked it ready for review 11/10/26, 12:24

  3. core-ci voted on patch set 1 V +1 11/10/26, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113896

  4. Markus Klein commented on patch set 2 V +1 11/10/26, 19:37

    Published edit on patch set 1.
  5. Markus Klein updated the commit message in patch set 3 11/10/26, 19:38

  6. Markus Klein commented on patch set 3 11/10/26, 19:38

    PackageManager.php:1046

    ```suggestion * The paths are evaluated on every call and not memorized, as extensions may be ```
  7. core-ci voted on patch set 2 V +1 11/10/26, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113941

  8. core-ci voted on patch set 3 V +1 11/10/26, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113942

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/15/26, 01:22

  10. Markus Klein commented on patch set 3 CR -1 11/18/26, 13:56

    PackageManager.php:1054

    this is NEVER written anywhere now
  11. Benni Mack commented on patch set 3 11/18/26, 13:58

    PackageManager.php:1054 Reply

    I did this on purpose in case others rely on it this way (typo3 console, extensions utilzing Testing framework)
  12. Markus Klein commented on patch set 3 11/18/26, 14:10

    PackageManager.php:1054 Reply Unresolved

    Hm.. this means this can only be done by classes extending this class. IMO we should add a clear comment for that intention, otherwise this will be killed by a refactoring.