Review main Ready for review

97520[BUGFIX] Guard global request access in admin panel

Lukas Witten CR 0 V 0 Easy +4 −4 updated 11/10/26, 15:07

Commit message

The admin panel no longer expects $GLOBALS['TYPO3_REQUEST'] to be
set when rendering. This allows rendering the panel for responses
returned by middlewares before the frontend RequestHandler, such as
redirects.

* MainController no longer triggers a warning if the global request
  is missing
* PreviewModule and CacheModule no longer fail without a global
  request and use their existing page id 0 fallback

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/20/97520/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/20/97520/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 4

Issues 1

Files 3

Review log 12

  1. Lukas Witten uploaded patch set 1 11/10/26, 14:55

  2. core-ci voted on patch set 1 V +1 11/10/26, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113916