Review main Ready for review

97521[BUGFIX] Resolve missing labels without LLL: prefix to empty string

Benni Mack CR 0 V 0 Normal +81 −5 updated 11/11/26, 13:53

Commit message

The LLL: prefix of a label reference is optional, which allows to
write translation domain references like "my_ext.messages:label".
LanguageService->sL() returned an empty string for a missing label
when the prefix was given, but the reference itself without it, so
both syntaxes behaved differently for the same missing label.

A missing label now results in an empty string as long as the
reference points to an existing language file or domain. Strings
with a colon that do not point to a language file, such as
"Note: read this", are still returned as they are.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/21/97521/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/21/97521/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 1

Issues 1

Files 3

Review log 23

  1. Benni Mack uploaded patch set 1 11/10/26, 17:44

  2. core-ci voted on patch set 1 V +1 11/10/26, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113927

  3. Benni Mack marked it ready for review 11/11/26, 13:53