97526[FEATURE] Load status report providers asynchronously
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 4
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/97526/4 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/97526/4 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 4
Issues 1
Files 16
- Build/Sources/TypeScript/reports/status-report.ts2new+74 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-100976-LoadStatusReportProvidersAsynchronously.rstnew+58 −0
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+16 −2
- typo3/sysext/reports/Classes/Controller/StatusReportController.php+68 −9
- typo3/sysext/reports/Classes/Service/StatusService.php2+29 −32
- typo3/sysext/reports/Configuration/Backend/AjaxRoutes.phpnew+12 −0
- typo3/sysext/reports/Configuration/JavaScriptModules.phpnew+11 −0
- typo3/sysext/reports/Resources/Private/Templates/StatusReport.fluid.html2+11 −19
- typo3/sysext/reports/Resources/Private/Templates/StatusReportProvider.fluid.htmlnew+22 −0
- typo3/sysext/reports/Resources/Public/JavaScript/status-report.jsnew+13 −0
- typo3/sysext/reports/Tests/Functional/Controller/StatusReportControllerTest.phpnew+179 −0
- typo3/sysext/reports/Tests/Functional/Fixtures/StatusProvider/FailingStatusProvider.phpnew+33 −0
- typo3/sysext/reports/Tests/Functional/Fixtures/StatusProvider/NoticeStatusProvider.phpnew+40 −0
- typo3/sysext/reports/Tests/Functional/Fixtures/StatusProvider/OtherStatusProvider.phpnew+37 −0
- typo3/sysext/reports/Tests/Functional/Fixtures/StatusProvider/WarningStatusProvider.phpnew+44 −0
- typo3/sysext/reports/Tests/Unit/Service/StatusServiceTest.php+71 −71
Review log 1519
-
Georg Ringer uploaded patch set 1 11/10/26, 21:37
-
core-ci voted on patch set 1 V +1 11/10/26, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113989
-
Georg Ringer commented on patch set 1 11/11/26, 08:49
This change is ready for review. -
Oli Bartsch uploaded patch set 2
V +111/11/26, 09:11 -
Oli Bartsch commented on patch set 2 11/11/26, 09:13
@georg.ringer@gmail.com The status report now sends one AJAX request per provider group label instead of one per provider class. Providers that share a label are merged and sorted together again, and the overall highest severity is stored at the end of each request, so the client-driven finalize route is gone. The provider endpoint now returns JSON with the HTML and the JavaScript items the providers registered. The module processes those items and fires a `typo3:reports:status-provider-loaded` DOM event once the markup is in the page. A provider that throws now shows up as an ERROR status and is counted as such, and a failed request shows an error callout. The install tool's "disable" link now points to the status module via UriBuilder, and adminCmd is passed on to the provider requests. The registry key is hashed, the dead collectAndStoreSystemStatus() is removed, the changelog documents the changed request context, assets, event and template variables. One open point: concurrent group requests may briefly store a slightly stale overall severity because Registry caches its values per request. -
core-ci voted on patch set 2 V +1 11/11/26, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114026
-
Oli Bartsch voted on patch set 2 CR +1 V +1 11/11/26, 09:59
-
Josef Glatz commented on patch set 2 V +1 11/12/26, 14:00
tested against some personal existing reports stuff in my playground. all fine. -
Andreas Kienast commented on patch set 2 11/12/26, 14:13
status-report.ts:23How is ensured that those elements actually exist when the module is loaded? I think we a `DocumentService.ready()` here... -
Georg Ringer uploaded patch set 3
CR +1V +111/12/26, 17:02 -
Georg Ringer commented on patch set 3 11/12/26, 17:02
status-report.ts:23ReplyDone -
core-ci voted on patch set 3 V +1 11/12/26, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114205
-
Josef Glatz voted on patch set 3 V +1 11/12/26, 17:30
-
Josef Glatz voted on patch set 3 CR +1 11/12/26, 19:09
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/14/26, 22:51
-
Josua Vogel commented on patch set 3 11/20/26, 11:57
StatusService.php:50After this patch getSystemStatus() has no caller left in the core. As the class is @internal, it could be removedStatusReport.fluid.html:24new label references should use the translation domain syntax -
Georg Ringer uploaded patch set 4
CR +1V +111/20/26, 19:46 -
Georg Ringer commented on patch set 4 11/20/26, 19:47
StatusService.php:50ReplyDoneStatusReport.fluid.html:24ReplyDone -
core-ci voted on patch set 4 V +1 11/20/26, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115086