Review main Merged

9753[TASK] PATH_site is defined twice in bootstrap

Andy Grunwald CR +2 V +2 Easy +0 −1 updated 06/03/13, 20:49

Commit message

In index.php AND typo3/sysext/cms/tslib/index_ts.php
(which will be included in index.php) the constant
PATH_site is defined.

The definition in typo3/sysext/cms/tslib/index_ts.php
is obsolete, because this will be checked via if(!defined(...)).

See also #35003

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andy Grunwald +1
  • Verified V +2
    • Christian Kuhn +2
    • Andy Grunwald +1

Files 1

Review log 11

  1. Georg Ringer commented on patch set 1 04/11/12, 11:50

    (1 inline comment)
    also 4.8
  2. Tolleiv Nietsch commented on patch set 2 04/11/12, 11:50

    Verified; Looks good to me, approved
  3. Stefan Neufeind commented on patch set 2 04/11/12, 11:50

    Looks good to me, but someone else must approve looks okay be reading source and your arguments
  4. Oliver Klee commented on patch set 2 04/11/12, 11:50

    Looks good to me, but someone else must approve
  5. Christian Kuhn uploaded patch set 3 04/11/12, 11:50

  6. Christian Kuhn commented on patch set 3 V 0 04/11/12, 11:50

    by team member; Looks good to me, approved
  7. Andy Grunwald uploaded patch set 2 04/11/12, 11:50

  8. Andy Grunwald commented on patch set 3 04/11/12, 11:50

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 04/11/12, 11:50

  10. Mr. Jenkins commented on patch set 2 04/11/12, 11:50

  11. Christian Kuhn merged patch set 3 04/11/12, 11:50