97537[FEATURE] Find the subpages of a page with one database query
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josua Vogel +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benni Mack +2
- Josua Vogel +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 6
- Feature #111406Find the subpages of a page with one database query
- Bug #93937Live search really slow for non admin users in large TYPO3 websites
- Bug #95812Record Statistics runs into an error when reaching it's limits
- Feature #99320Use database native common table expression to fetch page tree
- Bug #109583DatabaseIntegrityCheck->genTree() causes infinite recursion / max_prepared_stmt_count exhaustion on circular page references
- Bug #110080SlugService::resolveSubPages() ignores workspace overlays when autoUpdateSlugs propagates slugs
Files 33
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+11 −11
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+78 −94
- typo3/sysext/backend/Classes/Tree/View/PageTreeView.php+2 −3
- typo3/sysext/backend/Tests/Functional/Tree/View/Fixtures/PageTree.csvnew+21 −0
- typo3/sysext/backend/Tests/Functional/Tree/View/PageTreeViewTest.phpnew+132 −0
- typo3/sysext/core/Classes/Domain/Repository/PageDescendantsRepository.phpnew+335 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-111406-FindTheSubpagesOfAPageWithOneDatabaseQuery.rstnew+101 −0
- typo3/sysext/core/Tests/Functional/Domain/Repository/Fixtures/PageDescendants.csvnew+24 −0
- typo3/sysext/core/Tests/Functional/Domain/Repository/Fixtures/QueryCountingMiddleware.phpnew+61 −0
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageDescendantsQueryCountTest.phpnew+158 −0
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageDescendantsRepositoryTest.phpnew+219 −0
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+16 −45
- typo3/sysext/extbase/Tests/Functional/Configuration/ConfigurationManagerTest.php+12 −1
- typo3/sysext/impexp/Classes/View/ExportPageTreeView.php+2 −2
- typo3/sysext/impexp/Classes/Export.php+1 −1
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+3 −42
- typo3/sysext/info/Classes/Controller/PageInformationController.php+49 −56
- typo3/sysext/linkvalidator/Classes/Repository/PagesRepository.php+57 −35
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/PagesRepositoryTest/subpages.csvnew+20 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/PagesRepositoryTest.php+30 −0
Show 13 more files
- typo3/sysext/lowlevel/Classes/Controller/QuerySearchController.php+14 −31
- typo3/sysext/lowlevel/Tests/Functional/Controller/QuerySearchControllerTest.php+8 −4
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+14 −27
- typo3/sysext/redirects/Classes/EventListener/AddUrlsForSubPagesForIntegrityCheck.php+54 −33
- typo3/sysext/redirects/Classes/Service/SlugService.php+32 −31
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SlugServiceTest_workspace.csvnew+12 −0
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+2 −2
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceWorkspaceTest.phpnew+72 −0
- typo3/sysext/reports/Classes/Integrity/DatabaseIntegrityCheck.php+118 −90
- typo3/sysext/reports/Tests/Functional/Integrity/Fixtures/PageTree.csvnew+14 −0
- typo3/sysext/reports/Tests/Functional/Integrity/DatabaseIntegrityCheckTest.php+99 −20
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+20 −131
- typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php+13 −0
Review log 1925
-
Benni Mack uploaded patch set 1 11/11/26, 11:24
-
core-ci voted on patch set 1 V +1 11/11/26, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114063
-
Benni Mack uploaded patch set 2
V +111/11/26, 12:44 -
core-ci voted on patch set 2 V +1 11/11/26, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114073
-
Benni Mack uploaded patch set 3
V +111/11/26, 14:48 -
core-ci voted on patch set 3 V +1 11/11/26, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114102
-
Benni Mack marked it ready for review 11/11/26, 15:01
-
Benni Mack rebased onto patch set 4
V +111/11/26, 15:58 -
Benni Mack marked it ready for review 11/11/26, 16:13
-
core-ci voted on patch set 4 V +1 11/11/26, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114116
-
Wouter Wolters voted on patch set 4 CR +1 V +1 11/11/26, 21:17
-
Oli Bartsch commented on patch set 4 11/14/26, 16:07
I have created https://review.typo3.org/c/Packages/TYPO3.CMS/+/97654 which is a simple fix for the Database Integrity Check bug (109583). Seems this patch covers a lot more. Not sure if we could just accept the small bugfix and evaluate this afterwards. WDYT? -
Benni Mack commented on patch set 4 11/14/26, 16:43
Reply
yeah, this is my approach to do it right to never worry about broken setups anymore. The original report and the first patch by Stefan was about fixing an issue when a database is in corrupt state which I could not reproduce in a regular setup. I recommended to build a solution that its forward-looking than fixing a symptom. I can live ofc with your approach fixing the issue (again, only managed to reproduce it by manually changing things in my DB) and this one for a future change with a different issue number. -
Benni Mack uploaded patch set 5
CR +1V +111/15/26, 08:27 -
Benni Mack commented on patch set 5 11/15/26, 08:28
Reply
I changed the resolves line now to related, since your bugfix got in. -
core-ci voted on patch set 5 V +1 11/15/26, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114513
-
Wouter Wolters voted on patch set 5 CR +1 V +1 11/15/26, 11:34
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 11/15/26, 15:28
-
Josua Vogel voted on patch set 5 CR +1 V +1 11/16/26, 09:08
-
Benni Mack uploaded patch set 6
CR +1V +111/19/26, 08:41 -
core-ci voted on patch set 6 V +1 11/19/26, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114975
-
Benjamin Kott voted on patch set 6 CR +1 V +1 11/19/26, 10:07
-
Josua Vogel voted on patch set 6 CR +1 V +1 11/19/26, 11:36
-
Benni Mack voted on patch set 6 CR +2 V +2 11/21/26, 09:34
-
Benni Mack merged patch set 7 11/21/26, 09:34