Review 14.3 Merged

97539[BUGFIX] Report native field validation errors in FormEngine

Georg Ringer CR +2 V +2 Normal +45 −6 updated 11/11/26, 13:24

Commit message

Since FormEngine saves via `requestSubmit()`, the browser's
constraint validation runs before any submit handler. A field
with a natively invalid value, e.g. an invalid address in a
`type="email"` input, silently blocked saving if it was placed
in an inactive tab, as the browser cannot focus it.

FormEngine validation now takes the native validity state of a
field into account, so the field, its label and its tab are
marked as erroneous. This also covers the "bad input" state,
e.g. `1-2` in a number field, which the browser reports as an
empty value while still displaying the input. The `invalid`
event of such fields is intercepted to show the FormEngine
error modal instead.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 5

Files 4

Review log 45

  1. Georg Ringer uploaded patch set 1 11/11/26, 12:49

  2. Georg Ringer commented on patch set 1 11/11/26, 12:51

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/11/26, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114074

  4. Georg Ringer voted on patch set 1 CR +2 V +2 11/11/26, 13:24

  5. Georg Ringer merged patch set 2 11/11/26, 13:24