Review main Merged

9754[TASK] PATH_tslib is defined twice in bootstrap

Andy Grunwald CR +2 V +2 Easy +0 −12 updated 06/03/13, 20:49

Commit message

In index.php AND typo3/sysext/cms/tslib/index_ts.php
(which will be included in index.php) the constant
PATH_tslib is defined.

The definition in typo3/sysext/cms/tslib/index_ts.php
is obsolete, because this will be checked via if(!defined(...)).

In index.php, if PATH_tslib is empty the script will die immediately.
After that check, PATH_tslib will be used to include index_ts.php

See also #35003 and #35017

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andy Grunwald +1
  • Verified V +2
    • Christian Kuhn +2
    • Andy Grunwald +1

Files 1

Review log 16

  1. Georg Ringer commented on patch set 2 04/11/12, 11:35

    Looks good to me, but someone else must approve
    also 4.8.
  2. Andy Grunwald uploaded patch set 2 04/11/12, 11:35

  3. Tolleiv Nietsch commented on patch set 3 04/11/12, 11:35

    Verified; Looks good to me, approved
  4. Dmitry Dulepov commented on patch set 3 04/11/12, 11:35

    Looks good to me, but someone else must approve
  5. Stefan Neufeind commented on patch set 3 04/11/12, 11:35

    Looks good to me, but someone else must approve looks okay be reading source and your arguments
  6. Oliver Klee commented on patch set 3 04/11/12, 11:35

    Looks good to me, but someone else must approve
  7. Christian Kuhn uploaded patch set 4 04/11/12, 11:35

  8. Christian Kuhn commented on patch set 4 04/11/12, 11:35

    Just re-targeted to 6.0 and 4.7 only.
  9. Sebastian Fischer commented on patch set 3 04/11/12, 11:35

    Looks good to me, but someone else must approve
  10. Andy Grunwald uploaded patch set 3 04/11/12, 11:35

  11. Andy Grunwald commented on patch set 4 04/11/12, 11:35

    Verified; Looks good to me, but someone else must approve Yep. Looks good
  12. Mr. Jenkins commented on patch set 1 04/11/12, 11:35

  13. Mr. Jenkins commented on patch set 2 04/11/12, 11:35

  14. Mr. Jenkins commented on patch set 3 04/11/12, 11:35

  15. Christian Kuhn commented on patch set 4 V 0 04/11/12, 11:35

    by team member; Looks good to me, approved
  16. Christian Kuhn merged patch set 4 04/11/12, 11:35