Review main Merged

97546[BUGFIX] Avoid undefined array key in HrefLangGenerator

André Buchmann CR +2 V +2 Easy +31 −5 updated 11/14/26, 07:54

Commit message

If all languages of a site are disabled, the language menu
processor does not provide the "languagemenu" key, which led
to PHP warnings when generating hreflang tags, e.g. while
previewing such a site as a backend user.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. André Buchmann uploaded patch set 1 11/11/26, 15:07

  2. core-ci voted on patch set 1 V +1 11/11/26, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114105

  3. Oliver Klee voted on patch set 1 CR +1 V +1 11/11/26, 15:48

  4. Georg Ringer voted on patch set 1 CR +1 V +1 11/11/26, 15:51

  5. Jochen Roth voted on patch set 1 CR +1 V +1 11/11/26, 17:09

  6. Benni Mack voted on patch set 1 CR +2 V +2 11/14/26, 07:54

  7. Benni Mack merged patch set 2 11/14/26, 07:54