Review main Merged

97551[TASK] Route all cache flushes through CacheFlusher

Benni Mack CR +2 V +2 Hard +397 −48 updated 11/20/26, 16:20

Commit message

"Flush cache" in the install tool, the "cache:flush" command and
uninstalling an extension flushed caches without the CacheFlusher,
so listeners of AfterCacheFlushedEvent, for example a CDN purge,
never learned about these flushes.

CacheFlushDemand::forGroups() now flushes whole cache groups, and
errors reported by listeners of CacheFlushEvent are part of the
CacheFlushResult, so all three can use the CacheFlusher. Unknown
cache groups are skipped instead of throwing an exception, and
"cache:flush --group" reports them.

The install tool keeps flushing the caches once before loading
ext_localconf.php, so a broken extension cannot prevent it.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 16

Review log 68

  1. Benni Mack uploaded patch set 1 11/11/26, 15:56

  2. core-ci voted on patch set 1 V -1 11/11/26, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114114

  3. Benni Mack rebased onto patch set 2 V -1 11/13/26, 13:19

  4. core-ci voted on patch set 2 V +1 11/13/26, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114319

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/13/26, 18:28

  6. Wouter Wolters voted on patch set 2 CR +1 V +1 11/13/26, 23:44

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 11/20/26, 16:20

  8. Garvin Hicking merged patch set 3 11/20/26, 16:20