Review main Merged

97562[BUGFIX] List page translations below their default language page

Georg Ringer CR +2 V +2 Normal +57 −0 updated 11/18/26, 10:24

Commit message

The records list sorts pages by the sorting field, then by pid, the
language field and uid. A page translation shares its sorting value
and pid with the default language page, so the default language page
is always listed first and its translations follow directly below it,
also when listing pages of several levels.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1

Issues 1

Files 3

Review log 710

  1. Georg Ringer uploaded patch set 1 11/11/26, 20:20

  2. Georg Ringer commented on patch set 1 11/11/26, 20:21

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 11/11/26, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114140

  4. core-ci voted on patch set 1 V +1 11/18/26, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114140

  5. Oli Bartsch uploaded patch set 2 V +1 11/18/26, 09:27

  6. Oli Bartsch commented on patch set 2 11/18/26, 09:28

    The pages query in the record list now orders by sorting, pid, language field and uid, not just sorting and language field. A translation always has the same pid and sorting value as its default-language page. So translations stay grouped below their default page even when pages under different pids share a sorting value, for example when searching several levels. The uid adds a fixed final order. The fixture now has a second pid that reuses the same sorting values. The test uses a data provider to cover both the single-page list and the searchLevels case.
  7. Oli Bartsch voted on patch set 2 CR +1 V +1 11/18/26, 09:28

  8. Benni Mack commented on patch set 2 CR +2 V +2 11/18/26, 09:39

    DatabaseRecordList.php:2699

    I wonder why we need isLanguageAware here, because I think the whole backend would break if we disable this. But looking at this, I assume we need this for phpstan :)
  9. Benni Mack merged patch set 3 11/18/26, 09:39

  10. core-ci voted on patch set 2 V +1 11/18/26, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114838