Review 14.3 Merged

97563[BUGFIX] Apply extTarget to page links to other sites

Georg Ringer CR +2 V +2 Easy +36 −3 updated 11/14/26, 07:54

Commit message

Since the page type "Link" got full typolink support, the page link
builder starts with treating a link as internal and only ever resets
that flag to internal after generating the URL. A link to a page of
another site is rendered as an absolute URL, but was handled as an
internal link: `config.extTarget` was ignored and `config.intTarget`
or the target of the page record was used instead.

Treat a generated absolute URL as external again when there is no
current site or the target page belongs to another site, as before.
This also applies to pages of type "Link" pointing to a page of
another site.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Georg Ringer commented on patch set 1 11/11/26, 20:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/11/26, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114141

  3. Oli Bartsch uploaded patch set 2 V -1 11/12/26, 08:34

  4. core-ci voted on patch set 2 V +1 11/12/26, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114171

  5. Benni Mack voted on patch set 2 CR +2 V +2 11/14/26, 07:54

  6. Benni Mack merged patch set 3 11/14/26, 07:54