Review main Merged

97565[BUGFIX] Reflect pinned state on dashboard widget move button

Georg Ringer CR +2 V +2 Normal +76 −2 updated 11/12/26, 17:05

Commit message

The move button of a dashboard widget is a toggle. It now exposes
its state via aria-pressed and shows a title that describes the
action available while the widget is pinned.

The web test runner import map knows the marked and dompurify
modules, which the dashboard module needs to be loaded in tests.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Rath-Ulrich +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 78

  1. Georg Ringer uploaded patch set 1 11/11/26, 21:43

  2. Georg Ringer commented on patch set 1 11/11/26, 21:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/11/26, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114146

  4. Benni Mack voted on patch set 1 CR +1 V +1 11/12/26, 13:44

  5. Christian Rath-Ulrich voted on patch set 1 V +1 11/12/26, 16:27

  6. Josua Vogel voted on patch set 1 CR +1 11/12/26, 16:35

  7. Georg Ringer voted on patch set 1 CR +2 V +2 11/12/26, 16:56

  8. Georg Ringer merged patch set 2 11/12/26, 17:05