97572[BUGFIX] Allow tree data providers without database configuration
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsRemoveEmptyRelations.php+12 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php+4 −1
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectTreeItemsTest.php+38 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsRemoveEmptyRelationsTest.php+59 −0
- typo3/sysext/core/Classes/Tree/TableConfiguration/TreeDataProviderFactory.php+48 −37
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/Fixtures/TreeDataProviderWithoutDatabaseFixture.phpnew+29 −0
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/TreeDataProviderFactoryTest.php+29 −0
- typo3/sysext/styleguide/Classes/UserFunctions/FormEngine/TypeSelectTree8DataProvider.phpnew+74 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_select.php+17 −0
- typo3/sysext/styleguide/Tests/Functional/UserFunctions/FormEngine/TypeSelectTree8DataProviderTest.phpnew+91 −0
Review log 1116
-
Benni Mack uploaded patch set 1 11/12/26, 09:39
-
core-ci voted on patch set 1 V +1 11/12/26, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114173
-
Benni Mack uploaded patch set 2
V +111/12/26, 13:36 -
core-ci voted on patch set 2 V +1 11/12/26, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114189
-
Benni Mack uploaded patch set 3
V +111/12/26, 19:15 -
core-ci voted on patch set 3 V -1 11/12/26, 19:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114214
-
Benni Mack uploaded patch set 4
V -111/12/26, 19:32 -
core-ci voted on patch set 4 V +1 11/12/26, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114215
-
Georg Ringer voted on patch set 4 CR +1 V +1 11/12/26, 20:08
-
Garvin Hicking commented on patch set 4 CR -1 11/12/26, 20:18
reviewing -
Garvin Hicking uploaded patch set 5
CR +1V +111/12/26, 20:39remove ifEmpty requirement -
core-ci voted on patch set 5 V +1 11/12/26, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114228
-
Garvin Hicking commented on patch set 5 CR +1 V +1 11/12/26, 20:51
Reply
done. adapted that "ifEmpty" is not mandatory to be set so that the tree can be properly constituted without it. -
Georg Ringer voted on patch set 5 CR +1 V +1 11/12/26, 21:03
-
Benni Mack voted on patch set 5 CR +2 V +2 11/12/26, 21:04
-
Benni Mack merged patch set 6 11/12/26, 21:04