Review main Ready for review

97573[BUGFIX] Build select tree from workspace overlaid records

Benni Mack CR +1 V +1 Normal +109 −28 updated 11/20/26, 12:00

Commit message

A select field with renderType "selectTree" and "parentField" built
its tree by querying the live table for each node, although
FormEngine already fetched all workspace overlaid rows of the foreign
table. A record moved to another parent in a workspace was therefore
still shown below its live parent, and building the tree ran about
three queries per node.

TcaSelectTreeItems now hands over the fetched rows to the tree data
provider, as TcaCategory already does, and DatabaseTreeDataProvider
resolves parent and foreign_field relations from these rows.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/73/97573/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/73/97573/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Georg Ringer +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Georg Ringer +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Merge conflicts 3

Issues 1

Files 5

Review log 711

  1. Benni Mack uploaded patch set 1 11/12/26, 09:49

  2. core-ci voted on patch set 1 V +1 11/12/26, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114174

  3. Benni Mack rebased onto patch set 2 V +1 11/12/26, 20:15

  4. core-ci voted on patch set 2 V +1 11/12/26, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114220

  5. Benni Mack uploaded patch set 3 V +1 11/12/26, 21:11

  6. core-ci voted on patch set 3 V +1 11/12/26, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114240

  7. Benni Mack uploaded patch set 4 V +1 11/14/26, 11:39

  8. core-ci voted on patch set 4 V +1 11/14/26, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114448

  9. Georg Ringer voted on patch set 4 CR +1 V +1 11/14/26, 19:06

  10. Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/14/26, 20:10

  11. Josua Vogel voted on patch set 4 CR +1 V +1 11/20/26, 12:00