97575[FEATURE] Allow webhook messages to target specific webhooks
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/75/97575/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/75/97575/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
- main 97596[FEATURE] Add webhook finisher to the form framework
-
97575 [FEATURE] Allow webhook messages to target specific webhooks This change
Merge conflicts 2
Issues 2
Files 12
- typo3/sysext/core/Classes/Messaging/TargetedWebhookMessageInterface.php5new+41 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-111024-AllowWebhookMessagesToTargetSpecificWebhooks.rstnew+80 −0
- typo3/sysext/webhooks/Classes/MessageHandler/WebhookMessageHandler.php+35 −1
- typo3/sysext/webhooks/Documentation/AdvancedUsage/Index.rst+29 −0
- typo3/sysext/webhooks/Documentation/Triggers/_snippets/_OrderNotifier.phpnew+23 −0
- typo3/sysext/webhooks/Documentation/Triggers/_snippets/_OrderPlacedMessage.phpnew+33 −0
- typo3/sysext/webhooks/Documentation/Triggers/Index.rst+28 −0
- typo3/sysext/webhooks/Tests/Functional/MessageHandler/Fixtures/CollectingLogger.phpnew+33 −0
- typo3/sysext/webhooks/Tests/Functional/MessageHandler/Fixtures/sys_webhook.csvnew+6 −0
- typo3/sysext/webhooks/Tests/Functional/MessageHandler/Fixtures/TargetedTestMessage.phpnew+37 −0
- typo3/sysext/webhooks/Tests/Functional/MessageHandler/Fixtures/UntargetedTestMessage.phpnew+28 −0
- typo3/sysext/webhooks/Tests/Functional/MessageHandler/WebhookMessageHandlerTest.phpnew+146 −0
Review log 710
-
Josua Vogel uploaded patch set 1 11/12/26, 10:34
-
core-ci voted on patch set 1 V +1 11/12/26, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114178
-
Josua Vogel marked it ready for review 11/12/26, 15:58
-
Oli Bartsch commented on patch set 1 11/12/26, 21:27
TargetedWebhookMessageInterface.php:35This adds new public API whose only planned consumer, the EXT:form finisher, is not yet available. Whether UUIDs are the right key and how the form editor lists webhooks of a type (`WebhookRepository` and `WebhookTypesRegistry` are both `@internal`) can't really be judged without it. Could you push #111025 in a relation chain, so we can test this properly? -
Josua Vogel uploaded patch set 2
V +111/13/26, 08:03 -
Josua Vogel commented on patch set 2 11/13/26, 08:05
TargetedWebhookMessageInterface.php:30ReplyDoneTargetedWebhookMessageInterface.php:35ReplyYes, I pushed a WIP -
core-ci voted on patch set 2 V +1 11/13/26, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114283
-
Josua Vogel uploaded patch set 3
V +111/15/26, 16:16 -
core-ci voted on patch set 3 V +1 11/15/26, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114549
-
Josua Vogel commented on patch set 3 11/19/26, 10:23
TargetedWebhookMessageInterface.php:35ReplyDone
TargetedWebhookMessageInterface.php:30