Review main Merged

97576[BUGFIX] Stop delivering disabled webhooks from the runtime cache

Josua Vogel CR +2 V +2 Normal +133 −4 updated 11/13/26, 14:23

Commit message

The webhook message handler switched the shared WebhookRepository to
default restrictions and read the result from the runtime cache, whose
key ignored that switch. So whichever caller ran first decided whether
disabled webhooks were delivered, the switch leaked into later queries,
and a messenger:consume worker kept the webhook list of its first
message until it was restarted.

The handler now uses findActiveByType(), which always applies the
default restrictions and bypasses the runtime cache, and findAll()
caches restricted and unrestricted results separately.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 89

  1. Josua Vogel uploaded patch set 1 11/12/26, 10:56

  2. Josua Vogel marked it work in progress 11/12/26, 11:27

  3. Josua Vogel wrote 11/12/26, 11:27

    Unset private
  4. Josua Vogel rebased onto patch set 2 11/12/26, 13:59

  5. core-ci voted on patch set 2 V +1 11/12/26, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114191

  6. Josua Vogel commented on patch set 2 11/12/26, 15:32

    This change is ready for review.
  7. Benni Mack voted on patch set 2 CR +1 V +1 11/13/26, 10:08

  8. Georg Ringer voted on patch set 2 CR +2 V +2 11/13/26, 10:10

  9. Benni Mack merged patch set 3 11/13/26, 14:23